Fix yaml upon empty volumeMounts or volumes #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today it create illegal yaml with undefined volumeMounts and volumes yielding these messages from kubeval: WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.containers.0.volumeMounts: Invalid type. Expected: array, given: null WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.volumes: Invalid type. Expected: array, given: null Instead; insert empty lists.
|
|
arve0
reviewed
Apr 13, 2023
templates/tests/server-test.yaml
Outdated
| @@ -46,10 +46,14 @@ spec: | |||
| volumeMounts: | |||
| {{- if .Values.server.volumeMounts }} | |||
There was a problem hiding this comment.
Could also move the if statement one line up, to make it include the key, in example:
{{- if .Values.server.volumeMounts }}
volumeMounts:
{{- toYaml .Values.server.volumeMounts | nindent 8}}
{{- end }}
There was a problem hiding this comment.
Changed it now (better late than never)
tvoran
reviewed
Nov 28, 2023
|
Added some tests.... a long time after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it create illegal yaml with undefined volumeMounts and volumes yielding these messages from kubeval: WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.containers.0.volumeMounts: Invalid type. Expected: array, given: null WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.volumes: Invalid type. Expected: array, given: null
Instead; insert empty lists.